feat: add listings endpoint with pagination, filters, and tests#20
Merged
jaykayudo merged 3 commits intoTrajectfi:mainfrom Apr 30, 2025
Conversation
jaykayudo
suggested changes
Apr 30, 2025
Contributor
jaykayudo
left a comment
jaykayudo
left a comment
There was a problem hiding this comment.
@daveylupes Great job so far.
Please attend to the review changes and then this PR is ready to be merged
core/serializers.py
Outdated
Comment on lines
241
to
248
| listing_id = serializers.UUIDField(source="id", read_only=True) | ||
| collateral_contract = serializers.CharField( | ||
| source="nft_contract_address", read_only=True | ||
| ) | ||
| collateral_id = serializers.IntegerField(source="nft_token_id", read_only=True) | ||
| borrower_address = serializers.CharField(source="user.public_key", read_only=True) | ||
| loan_amount = serializers.IntegerField(source="borrow_amount", read_only=True) | ||
| loan_duration = serializers.IntegerField(source="duration", read_only=True) |
Contributor
There was a problem hiding this comment.
Please remove these attributes. simply defining them in the Meta class fields attribute is okay.
core/serializers.py
Outdated
| class Meta: | ||
| model = Listing | ||
| fields = [ | ||
| "listing_id", |
Contributor
There was a problem hiding this comment.
lisiting id does not exist in the model. use id instead.
jaykayudo
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement the
GET /listingsendpoint to fetch all active collateral listings in the lending protocol. This endpoint supports pagination and filtering bycollateral_contractandborrower_address. Returned fields includelisting_id,collateral_contract,collateral_id,borrower_address,loan_amount,loan_duration,created_at, andstatus.Related Issue
Fixes #19
Type of Change
How Has This Been Tested?
Tests are located in
core/tests/test_listings.pyand include:active records.collateral_contract.borrower_address.Run this command for single test of the function implemented;
Python Dependencies
Starknet-Specific Considerations
N/A
Checklist
Security Considerations
Performance Impact