Skip to content

fix(ui): seed CCXT select defaults and validate connection fields in account wizard #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WillHoooo wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(ui): seed CCXT select defaults and validate connection fields in account wizard #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions ui/src/pages/TradingPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,13 @@ function CreateWizard({ brokerTypes, existingAccountIds, onSave, onClose }: {
if (!bt) return
const defaults: Record<string, unknown> = {}
for (const f of bt.fields) {
if (f.default !== undefined) defaults[f.name] = f.default
if (f.default !== undefined) {
defaults[f.name] = f.default
} else if (f.type === 'select' && f.options?.length) {
// Controlled <select> with value "" does not fire onChange when the UI shows the
// first option — user must pick explicitly or we seed the first value here.
defaults[f.name] = f.options[0].value
}
}
setBrokerConfig(defaults)
}, [type])
Expand All @@ -386,12 +392,20 @@ function CreateWizard({ brokerTypes, existingAccountIds, onSave, onClose }: {
badgeColor: b.badgeColor,
}))

const connectionRequiredOk = connectionFields
.filter(f => f.required)
.every(f => String(brokerConfig[f.name] ?? '').trim())

const handleNext = () => {
if (!type) return
if (existingAccountIds.includes(finalId)) {
setError(`Account "${finalId}" already exists`)
return
}
if (hasSensitive && !connectionRequiredOk) {
setError('Please complete all required connection fields')
return
}
setError('')
if (hasSensitive) {
setStep(2)
Expand Down Expand Up @@ -420,7 +434,8 @@ function CreateWizard({ brokerTypes, existingAccountIds, onSave, onClose }: {
}

const canCreate = hasSensitive
? credentialFields.filter(f => f.required).every(f => String(brokerConfig[f.name] ?? '').trim())
? connectionRequiredOk &&
credentialFields.filter(f => f.required).every(f => String(brokerConfig[f.name] ?? '').trim())
: true

return (
Expand Down Expand Up @@ -497,7 +512,11 @@ function CreateWizard({ brokerTypes, existingAccountIds, onSave, onClose }: {
</button>
)}
{step === 1 && (hasSensitive || !type) && (
<button onClick={handleNext} disabled={!type} className="btn-primary">
<button
onClick={handleNext}
disabled={!type || (hasSensitive && !connectionRequiredOk)}
className="btn-primary"
>
Next
</button>
)}
Expand Down