#2259: Use a Chartjs-ror version with airblade/chartjs-ror#57 applied… #2260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…applied. Adds a container around each chart allowing to enable responsivity and get a less fuzzy chart.
Member
Author
|
@mattr-, any ideas why this is failing? |
Member
|
The initial failures in CI made no sense, but I'm happy to just run CI at pull request time. |
Member
Author
|
It seems that the CI checks finally passed after I changed the Git repository link to master instead of a branch (which doesn't seem like it should cause an error, but it did), and when I removed the push CI action (which seemed to cause some of the more recent fails, because one check failed and another one didn't). Dunno why, but for me this seems ok now. |
mattr-
approved these changes
Nov 13, 2019
Member
|
Having removed |
Member
Author
|
Should it? As I understand it, all changes to master come through pull requests, which means that each change to master has a CI build done anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a container around each chart allowing to enable responsivity and get a less fuzzy chart.
The PR in upstream hasn't moved for a month, so quickfixing this by referencing straight to the Github repository. Can be changed back to follow upstream once airblade/chartjs-ror#57 is merged.
Fixes #2259.