fix potensial bug: when n_importance not divided by up_sample_steps w…#30
Open
murumura wants to merge 1 commit intoTotoro97:mainfrom
Open
fix potensial bug: when n_importance not divided by up_sample_steps w…#30murumura wants to merge 1 commit intoTotoro97:mainfrom
murumura wants to merge 1 commit intoTotoro97:mainfrom
Conversation
…ill cause ret_fine[s_val] reshape error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential bug:
in
renderer.pyWhenself.n_importanceis not divisible byself.up_sample_stepswill cause line 365 inrenderer.pyreshape error due to shape differ.For example when setting
self.up_sample_steps=6andself.n_importance=64andself.n_samples=64it will result tensorsdfin last iteration of up sample loop to have shape of(batch_size, 124)(since 64//6=10, we missing the non-zero remainder at each loop-iteration) instead of(batch_size, 128).While in line 341
n_samples = self.n_samples + self.n_importanceresult 128 instead of 124, so this will makes_val = ret_fine['s_val'].reshape(batch_size, n_samples).mean(dim=-1, keepdim=True)to cause a reshape error.I simply add accumulative non-zero reminder to
n_importanceargument passed toself.up_sampleat last iteration to resolve this bug.