-
-
Notifications
You must be signed in to change notification settings - Fork 245
Toolbar updates #1438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbar updates #1438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the user interface for the edit toolbar in the library view, implements functionality to hide the mini player when the keyboard is visible, and fixes scroll offset issues in the Account screen.
Changes:
- Renamed
publicIdtoexternalIdin PasskeyLoginResponse model to align with backend API - Added KeyboardObserver to detect keyboard visibility and conditionally hide the mini player
- Redesigned the edit mode toolbar with a Files-app-style layout grouping edit/move/delete buttons with a Menu for additional options
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Shared/Services/Account/PasskeyModels.swift | Renamed field from publicId to externalId for consistency with backend API |
| BookPlayer/Utils/Extensions/View+BookPlayer.swift | Added KeyboardObserver class and updated MiniPlayerSafeAreaInsetModifier to handle keyboard visibility |
| BookPlayer/Profile/Account/AccountView.swift | Added miniPlayerSafeAreaInset modifier to fix scroll offset issues |
| BookPlayer/MainView.swift | Integrated KeyboardObserver to hide mini player when keyboard is shown |
| BookPlayer/Library/ItemList/ItemListView.swift | Redesigned edit toolbar with grouped buttons and added itemOptionsMenu as Menu alternative to confirmation dialog |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9734870 to
0433382
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Purpose