Skip to content

Conversation

@GianniCarlo
Copy link
Collaborator

Purpose

  • There's a new look for the edit toolbar in the library view, to be more in line with how Files does things
  • Hide mini player when the keyboard is shown
  • Fix scroll offset in the Account screen, so mini player does not cover content

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the user interface for the edit toolbar in the library view, implements functionality to hide the mini player when the keyboard is visible, and fixes scroll offset issues in the Account screen.

Changes:

  • Renamed publicId to externalId in PasskeyLoginResponse model to align with backend API
  • Added KeyboardObserver to detect keyboard visibility and conditionally hide the mini player
  • Redesigned the edit mode toolbar with a Files-app-style layout grouping edit/move/delete buttons with a Menu for additional options

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Shared/Services/Account/PasskeyModels.swift Renamed field from publicId to externalId for consistency with backend API
BookPlayer/Utils/Extensions/View+BookPlayer.swift Added KeyboardObserver class and updated MiniPlayerSafeAreaInsetModifier to handle keyboard visibility
BookPlayer/Profile/Account/AccountView.swift Added miniPlayerSafeAreaInset modifier to fix scroll offset issues
BookPlayer/MainView.swift Integrated KeyboardObserver to hide mini player when keyboard is shown
BookPlayer/Library/ItemList/ItemListView.swift Redesigned edit toolbar with grouped buttons and added itemOptionsMenu as Menu alternative to confirmation dialog

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GianniCarlo GianniCarlo merged commit 62981f5 into develop Jan 28, 2026
1 check passed
@GianniCarlo GianniCarlo deleted the fix/toolbar branch January 28, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants