fix #20
Merged
fix #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for synchronous void delegates (Action/Action) in background workers, in addition to the existing async delegate support (Func/Func<T, Task>). Previously, only async delegates or synchronous delegates returning Task were properly handled.
Changes:
- Updated delegate analysis logic to distinguish between async and sync delegates
- Modified code generation to conditionally await async delegates or directly invoke sync delegates
- Updated delegate type generation to return Action for sync delegates and Func for async delegates
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/MinimalWorker.Generators/WorkerGenerator.cs | Added logic to handle sync (void) vs async (Task) delegate return types, with whitespace cleanup |
| src/MinimalWorker.Generators/WorkerEmitter.cs | Updated GetDelegateType to return Action for sync delegates and modified all three worker init methods to conditionally await based on delegate type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.