Enable licensing #17
Open
Enable licensing #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 20, 2017 18:27
API key is a necessary component in SDK licensing. Users must fill the API key belong to them when using SDK. In this commit, we add a new parameter "apiKey" to fill their API key, and implement client-side authentication message when sending request to get media resource. We also write tests about "apiKey" parameter.
The original signature generating method is time costing. To make performance better, we removed the pbkdf2-hashed part and only used bcrypt-hashed part.
To make the SDK licensing protocol more secure, we should also verify the verification message from response. In implementation, we use bcrypt to verify the message.
Originally, the response timestamp is stored in "timestamp" field of body. The new version of response stores timestamp in "X-Date" field of header. We modified the method of getting timestamp in response in this commit.
- Minimize bcryptjs: When we use bcryptjs, the built file size increases dramatically (~100KB in gzip) bacause Webpack detects it may uses crypto library and load the whole browserified version of crypto. To prevent from loading the whole crypto library, we maintained our bcryptjs which does not require it. The size of bcryptjs in built file is only about 10KB in gzip. - Minimize Bluebird We use promisify function in Bluebird and the size of Bluebird in built file size is about 20KB. To reduce the size, we use our own promisify function instead of Bluebird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Licensing is one important phase of Verpix pay system. Users want to use viewer should fill an API key associated to them. The viewer uses the API key to generate an authorization message, sends the message to Verpix servers, and get a response which contains a verification message and related resources. In this PR, I implemented the licensing protocol and the test cases.