Remove startup delay in Services constructor #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
marc1uk
force-pushed
the
replacedelay
branch
from
a63557e to
b06f473
Compare
…he timeout ineffective
marc1uk
force-pushed
the
replacedelay
branch
from
b06f473 to
1e5991f
Compare
Contributor
Author
|
alright hang on, the backend services has a thread that does all the sending/receiving and this poll is in the main application, which then raises an assertion failed because zmq sockets aren't thread-safe. 😑 |
Merged
marc1uk
force-pushed
the
replacedelay
branch
from
1e5991f to
4da4ac7
Compare
Contributor
Author
|
ok sorted, added a mutex lock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and replace with a call to Ready (poll zmq output sockets for listener). This only waits as long as is necessary.
Builds on PR #35