-
Notifications
You must be signed in to change notification settings - Fork 0
Organizational Folders | File re-arrangement | index size trimming #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sjkd23
wants to merge
22
commits into
main
Choose a base branch
from
cmdUtils
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… roll again with button. | database commands | Schema re-org | formatting |
…stants outside of command files. prettier roll.ts code.
ewang2002
requested changes
Sep 24, 2023
| if (commandName === CMD_LIST[i].info.name) { | ||
| CMD_LIST[i].run(interaction); | ||
| } else { | ||
| continue; |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need this
| DM.addChoiceOptions(); | ||
|
|
||
| const cmdInfo = CMD_LIST.map(cmd => cmd.info.toJSON()); | ||
| await rest.put( |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think about making a similar function (or refactoring this one) to allow for deploying commands globally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added utilities and database folders which contain:
utilities:
- cmdUtils (sets up and runs commands)
- miscUtils (the general utils that were previously in the 'utils.ts' file)
database:
- All database related files
- DBUtils.ts
- JeffreyDB.ts
- JeffreyGacha.ts
- DBMain.ts
constants:
- buttonConstants.ts (button related constants)
- miscConstants ( general constants, currently has number emojis and time_in_ms)