Skip to content

fix: remove quest enum refs not in RuneLite API (#60)#61

Merged
AhDoozy merged 2 commits intoToofifty:masterfrom
mads-jm:fix/issue-60-missing-quests
Feb 10, 2026
Merged

fix: remove quest enum refs not in RuneLite API (#60)#61
AhDoozy merged 2 commits intoToofifty:masterfrom
mads-jm:fix/issue-60-missing-quests

Conversation

@mads-jm
Copy link
Contributor

@mads-jm mads-jm commented Jan 27, 2026

Hey gang! Long-time user, first-time contributor :)
This should get the plugin back working in RuneLite.
Would love to help maintain and improve this project.

It's been a year or two since I touched Java, but I had a LOT of fun reading through the codebase / PR history before trying to resolve #60

Short Description

Fix plugin incompatibility error (#60) by removing Quest enum references not present in RuneLite API, and resolve 7 pre-existing test failures present since #42 was merged by the looks of it.

What Has Changed

⚠️ Commit 1: fix: remove quest enum refs not in RuneLite API (#60)

  • Removed Quest.AN_EXISTENTIAL_CRISIS and Quest.IMPENDING_CHAOS from QuestRequirements.java (not in current RuneLite API)

This is preventing usage from Plugin Hub currently


🧪 Commit 2: fix: resolve failing unit tests

  • GoalSerializerTest.java — Added @BeforeEach to inject Gson via reflection (fixes NPE)
  • TaskUpdateServiceTest.java — Added missing client.isClientThread() mock to 2 tests
  • QuestRequirementsTest.java — Updated assertions for recursive requirements (8 total, proper indent counts)
  • data.json / complex.jsonprevious_resultstatus, added pinned: false, normalized line endings

Steps for Reviewing

  1. Verify build passes: ./gradlew build
  2. Confirm all 91 tests pass: ./gradlew test
  3. Review QuestRequirements.java lines 1174–1185 for removed quest refs
  4. Review test file changes for serialization/mock fixes

Relevant tests

  • GoalSerializerTest.java
  • TaskUpdateServiceTest.java
  • QuestRequirementsTest.java

drop AN_EXISTENTIAL_CRISIS and IMPENDING_CHAOS from QuestRequirements list
@mads-jm mads-jm marked this pull request as ready for review January 27, 2026 06:05
@mads-jm
Copy link
Contributor Author

mads-jm commented Jan 27, 2026

@Toofifty @cecilia-sanare
Able to review/merge?

@Shajeeb4
Copy link

Thanks for having a look at this, hopefully get's published soon :)

@mads-jm
Copy link
Contributor Author

mads-jm commented Feb 4, 2026

@AhDoozy ?

@AhDoozy
Copy link
Collaborator

AhDoozy commented Feb 9, 2026

Sorry for the delay, I haven't had much free time since my son turned 6 months lol

@mads-jm - I assume you've fully tested these changes?

It's going to take me some time to get my new laptop setup for this development again.

@mads-jm
Copy link
Contributor Author

mads-jm commented Feb 9, 2026

@AhDoozy no worries!
Have been using it actively for about a week, nothing but existing issues thus far : )

@AhDoozy AhDoozy self-assigned this Feb 9, 2026
Copy link
Collaborator

@AhDoozy AhDoozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, plugins loads, adds, removes and discovers completed goals successfully

@AhDoozy AhDoozy merged commit 21135ea into Toofifty:master Feb 10, 2026
1 check failed
@Shajeeb4
Copy link

Sorry for the delay, I haven't had much free time since my son turned 6 months lol

@mads-jm - I assume you've fully tested these changes?

It's going to take me some time to get my new laptop setup for this development again.

Wishing you well with your son, mine just turned 11 months. Do cherish every moment as time goes past so quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin is Incompatible

3 participants