fix: remove quest enum refs not in RuneLite API (#60)#61
fix: remove quest enum refs not in RuneLite API (#60)#61AhDoozy merged 2 commits intoToofifty:masterfrom
Conversation
drop AN_EXISTENTIAL_CRISIS and IMPENDING_CHAOS from QuestRequirements list
|
@Toofifty @cecilia-sanare |
|
Thanks for having a look at this, hopefully get's published soon :) |
|
@AhDoozy ? |
|
Sorry for the delay, I haven't had much free time since my son turned 6 months lol @mads-jm - I assume you've fully tested these changes? It's going to take me some time to get my new laptop setup for this development again. |
|
@AhDoozy no worries! |
AhDoozy
left a comment
There was a problem hiding this comment.
tested, plugins loads, adds, removes and discovers completed goals successfully
Wishing you well with your son, mine just turned 11 months. Do cherish every moment as time goes past so quickly |
Hey gang! Long-time user, first-time contributor :)
This should get the plugin back working in RuneLite.
Would love to help maintain and improve this project.
It's been a year or two since I touched Java, but I had a LOT of fun reading through the codebase / PR history before trying to resolve #60
Short Description
Fix plugin incompatibility error (#60) by removing Quest enum references not present in RuneLite API, and resolve 7 pre-existing test failures present since #42 was merged by the looks of it.
What Has Changed
fix: remove quest enum refs not in RuneLite API (#60)Quest.AN_EXISTENTIAL_CRISISandQuest.IMPENDING_CHAOSfromQuestRequirements.java(not in current RuneLite API)🧪 Commit 2:
fix: resolve failing unit testsGoalSerializerTest.java— Added@BeforeEachto inject Gson via reflection (fixes NPE)TaskUpdateServiceTest.java— Added missingclient.isClientThread()mock to 2 testsQuestRequirementsTest.java— Updated assertions for recursive requirements (8 total, proper indent counts)data.json/complex.json—previous_result→status, addedpinned: false, normalized line endingsSteps for Reviewing
./gradlew build./gradlew testQuestRequirements.javalines 1174–1185 for removed quest refsRelevant tests
GoalSerializerTest.javaTaskUpdateServiceTest.javaQuestRequirementsTest.java