Skip to content

fix: not working properly on esm mode, specifically in Deno #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CGQAQ wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: not working properly on esm mode, specifically in Deno #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions bindings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,22 @@ exports.getFileName = function getFileName(calling_file) {
var origPST = Error.prepareStackTrace,
origSTL = Error.stackTraceLimit,
dummy = {},
fileName;
fileName,
fileSchema = 'file://';


Error.stackTraceLimit = 10;

Error.prepareStackTrace = function(e, st) {
for (var i = 0, l = st.length; i < l; i++) {
fileName = st[i].getFileName();

// if the mode is esm, the filename will be a URL
// so we need convert it to a path in order to compare with __dirname
if (fileName.indexOf(fileSchema) === 0) {
fileName = fileURLToPath(fileName);
}

if (fileName !== __filename) {
if (calling_file) {
if (fileName !== calling_file) {
Expand All @@ -176,7 +185,6 @@ exports.getFileName = function getFileName(calling_file) {
Error.stackTraceLimit = origSTL;

// handle filename that starts with "file://"
var fileSchema = 'file://';
if (fileName.indexOf(fileSchema) === 0) {
fileName = fileURLToPath(fileName);
}
Expand Down