Fix undefined fileName in getFileName #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to find the file name of the caller, getFileName grabs a stack trace and attempts to walk up it to find the first file name that is not the bindings.js file. For some reason, in my environment, the bindings.js file name is 'undefined' (see output below). In this case 'undefined' !== __filename and the for loop is stopped, leaving fileName undefined and causing an error when indexOf is invoked on fileName. To fix, an additional check for undefined fileName is added in the loop. fileName: undefined function: getFileName fileName: undefined function: bindings fileName: undefined function: eval fileName: /projects/node-crfpp/node-crfpp-bundle.js function: ./node-crfpp.js
Author
|
Potential fix for #54 |
|
Any progress on this? |
|
@TooTallNate Please review and merge to upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to find the file name of the caller, getFileName grabs a stack
trace and attempts to walk up it to find the first file name that is not the
bindings.js file. For some reason, in my environment, the bindings.js file
name is 'undefined' (see output below). In this case 'undefined' !== __filename
and the for loop is stopped, leaving fileName undefined and causing an error
when indexOf is invoked on fileName. To fix, an additional check for undefined
fileName is added in the loop.
fileName: undefined
function: getFileName
fileName: undefined
function: bindings
fileName: undefined
function: eval
fileName: /projects/node-crfpp/node-crfpp-bundle.js
function: ./node-crfpp.js