Merged
Conversation
This reverts commit e22bf2d.
targets 2023.2 and make the associated gradle version, plugin, java version change. note that things are very broken at this commit - we will need to fix tests and other stuff in the coming commits
LightCodeInsightFixtureTestCase was deprecated - we needed to update how we set up the ProjectDescriptor as well. Per IDEA-225960, internalJdk will be increasingly deprecated - IDEA seems to updated the internal disposal logic so our static initialization no longer works - they have created fake jdk for test usage - but there seems to be some slight behavior change (e.g. no fully qualified name) that we should probably update separately
HierarchyBrowserBase updated its createTrees generic variance and removed some method - this commit changes the children to follow
project component has been deprecated - in this commit, we migrate to MotifProjectService and AnalyticsProjectService
For some reason, our old way of adding libraries to the test environment stopped working and we need to use a different way. Also, the test rule need to be updated since the test environment now is more properly "faked" and the old rule hangs forever
Since that was leftover from ProjectComponent
* prefer Uber Motif to make plugin easier to identify * fix null pointer exception for icon load
We did a partial removal in an earlier commit and unintentionally made the TestHarness skip its tests. This commit removes the rule altogether and fixes the setUp/tearDown calls by removing the annotation (annotation not needed), see https://github.com/JetBrains/intellij-community/blob/master/platform/testFramework/src/com/intellij/testFramework/UsefulTestCase.java#L91
1. setting the jvm target in a more succinct way 2. avoid noisy build due to spotless depending on its own output diffplug/spotless#870 (comment)
This commit is to keep the build somewhat in line with RIBs and other uber open source projects
Thie commit prefers the slightly newer style of gradle plugin specification
This avoids the infinite poetry in uber#255
These modules don't seem to use kapt in the gradle. More importantly, having those lines prevented dokka from completing due to gradle complaining about task dependencies when trying to publish the change to local maven
While determining whether to create a no-arg convenience constructor, we check for both explicit (creatable) dependencies in addition to unsatisfied sinks to avoid generating incompatible code
The most important ones being the changes in IntelliJType.kt; the old ones are marked for removal.
This commit follows the naming pattern we use for the compiler/compiler-ast module nesting. Note that these tests/samples modules are not published so these namings are purely for consistency reason and ease of identification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save v1 changes