Skip to content

Optimize extend_safe function performance using set-based lookups #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
allrob23 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Optimize extend_safe function performance using set-based lookups #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rebulk/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,11 @@ def extend_safe(target, source):
:param source:
:type source: list
"""
target_set = set(target)
for elt in source:
if elt not in target:
if elt not in target_set:
target.append(elt)
target_set.add(elt)


class _Ref:
Expand Down