Conversation
Tochemey
requested changes
Dec 16, 2024
Owner
Tochemey
left a comment
Tochemey
left a comment
There was a problem hiding this comment.
We should not add net9 support for now. It has not yet been battle tested yet as far as I am concerned.
Owner
|
@TadijaB can you please update the PR with an updated version of the .NET Core in the ci.yml https://github.com/Tochemey/NetCore8583/blob/main/.github/workflows/ci.yml#L34-L37 |
System.Text.Encoding.CodePages v9 stopped supporting dotnet 7 and below, this change uses v9 when dotnet 8 or above are used to build the project. Replaced deprecated PackageLicenseUrl tag with PackageLicenseFile which references the existing License file. Updated ci.yml
Tochemey
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.Text.Encoding.CodePages v9 stopped supporting dotnet 7 and below, this change uses v9 when dotnet 8 or above are used to build the project.
Replaced deprecated PackageLicenseUrl tag with PackageLicenseFile which references the existing License file
closes #33