Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 482e74fb31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .replace(/\{\{message\}\}/g, ctx.message) | ||
| .replace(/\{\{model\}\}/g, ctx.model) | ||
| .replace(/\{\{cwd\}\}/g, ctx.cwd) |
There was a problem hiding this comment.
Preserve literal template tokens in user prompts
The arg renderer substitutes {{message}} and then continues replacing {{model}}, {{cwd}}, and {{resume}} on the resulting string, so a user message that literally contains those tokens gets rewritten before it reaches the provider (for example, asking about {{model}} syntax will inject the actual model id). This corrupts prompt content and can change model behavior; placeholder expansion should not run over user-provided text.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Literally cant launch the command without it
| if [[ "$MODEL_CHOICE" =~ ^[sS]$ ]]; then | ||
| echo -e "${YELLOW}Using default model: ${MODEL_IDS[0]}${NC}" | ||
| MODEL="${MODEL_IDS[0]}" |
There was a problem hiding this comment.
Avoid deriving default model from sorted map keys
When users choose the skip/default path, the wizard sets MODEL to MODEL_IDS[0], but MODEL_IDS is built via jq ... keys[] (sorted lexicographically), not by intended preference order. With the current registry this can silently select unexpected defaults (e.g., Anthropic defaults to claude-opus-4-6, OpenAI to gpt-5.2), which changes cost/quality characteristics for newly configured agents.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Irrelevant, it shows a list its only if you skip
|
A local stt and tts pipeline would now be trivial to add as a channel, and from there turning it into voice notes on other channels would be equally trivial. |
|
thanks for the amazing work |
Uh oh!
There was an error while loading. Please reload this page.