Skip to content
This repository was archived by the owner on Nov 21, 2021. It is now read-only.

Conversation

@Okamoi
Copy link
Contributor

@Okamoi Okamoi commented Sep 20, 2017

This only works on Windows 7, and probably not on Firefox 57 or Windows 10. Unless I forget I'll post a Photon-specific CSS after the 57 is released.

Looks like this: https://s26.postimg.org/u6w5t4nu1/Tabs-bottom-of-window.png

A couple bugs in fullscreen:
1/ The padding at the bottom of the window does not disappear.
2/ Top-of-the-window UI, while it disappears correctly and reappears just fine when moving the mouse near the top of the screen, doesn't disappear again. (Work around: Turn off full screen and then on again)

Reddit's /u/marciiF is to thank for this, he agreed that it is GPLv3.

@Okamoi
Copy link
Contributor Author

Okamoi commented Sep 20, 2017

I removed padding in full screen but there is a bug when the Menu bar is enabled, can't fix it right now

@Timvde
Copy link
Owner

Timvde commented Sep 21, 2017

There is already a PR open that moves tabs to the bottom. A lot of discussion went in it already, maybe you can join the converation?

@Timvde
Copy link
Owner

Timvde commented Sep 22, 2017

Ah, I was too quick in judging (and probably misread the title)! This doesn't move tabs to the bottom of the toolbar (like in Firefox 3), but to the bottom of the window. However, I'm still curious how this will work without a title bar. I'll try to test it as soon as possible. Maybe the PR I linked in my earlier commit still has useful tricks to include here :)

@andreicristianpetcu
Copy link
Contributor

Works fine on GNU/Linux. Tested on Ubuntu with Unity.

@andreicristianpetcu
Copy link
Contributor

made a video with this. Works with Gnome also https://vimeo.com/236199843

@Timvde
Copy link
Owner

Timvde commented Dec 17, 2017

This looks, sadly enough, really broken on Windows 10 :( The tab bar at the bottom isn't high enough, and the entire title bar/window controls at the top is gone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants