Enable direct+HKDF-SHA algorithms to be used in recipients #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR does have an API change that for MacMessage and EncMessage, the direct shared key needs to be set on the first recipient instead of on the message itself (because the message layer-0 key is always derived from a recipient key). I think this was an inconsistency in the original API for direct key use, but there could be a workaround for API compatibility (e.g. only set the |
Contributor
Author
|
If there is a need for direct+HKDF-SHA-256 test inputs, one of the examples from RFC 5869 could be used (one has a salt and one does not). |
BrianSipos
force-pushed
the
130-enable-direct-hkdf-sha
branch
from
65658ba to
bb415b2
Compare
BrianSipos
force-pushed
the
130-enable-direct-hkdf-sha
branch
from
bb415b2 to
fdda499
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deals only with the SHA-2 variants of direct+HKDF, not the AES-MAC variants (which I don't fully understand to even try to implement).
Closes #35
Closes #130
Closes #139