Add fully specified ECDSA and EdDSA algorithms #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianSipos
force-pushed
the
126-fully-specified-dsa
branch
from
f80f907 to
dbf652d
Compare
|
BrianSipos
commented
Oct 12, 2025
| """ Fully-specified ECDSA family. """ | ||
| @classmethod | ||
| @abstractmethod | ||
| def get_cose_curve_fullname(cls) -> str: |
Contributor
Author
There was a problem hiding this comment.
This could also be moved into _Ecdsa and changed to return Optional[str] so that the polymorphic derived classes return default None.
That would avoid mostly duplicate definitions of sign() and verify().
BrianSipos
force-pushed
the
126-fully-specified-dsa
branch
from
dbf652d to
d1c7424
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is on top of #127, as it may need more work.
Closes #126