Added tests for schema migration#220
Open
Electricschmidt wants to merge 2 commits intoTimmoth:mainfrom
Open
Conversation
Owner
|
Thanks for that Tom! What I had in mind was that we'd use the versioned YAML files in the test project (currently used in the schema validation tests https://github.com/Timmoth/RackPeek/blob/main/Tests/Yaml/SchemaTests.cs) So the test would look like one of the other e2e CLI tests (choose an arbitrary command like 'summary') since they read / migrate / save the source yaml file on startup. e.g Then we just have to make sure there exists at least one v1 yaml file which exhibits a property that needs migrating. WDYT? |
Author
|
Yeah, that sounds more useful long term tbf. I wrote these barebones tests mostly just to see if I understood what the expectation was but I can look at doing the e2e versions instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for issue #179. There's a bit of a question about whether or not the
List<object>case in theConvertScalarRunsOnToListis really valid also as I think the yaml would fail validation prior to this right?