Merged
Conversation
Implements a Soroban oracle price feed contract demonstrating: - set_price / get_price / get_timestamp / is_stale functions - Per-asset price + timestamp stored in persistent storage - Admin-gated price updates with staleness TTL - README showing how to debug stale price scenarios with the debugger - Storage diff walkthrough for price updates - 9 unit tests covering all functions and error paths
- Created test_get_timestamp.1.json to validate timestamp retrieval. - Added test_initialize_and_set_get_price.1.json for initializing and setting price. - Introduced test_invalid_price_rejected.1.json to ensure invalid price submissions are rejected. - Implemented test_price_becomes_stale_after_ttl.1.json to check price staleness after TTL expiration. - Added test_price_not_stale_immediately_after_update.1.json to verify price remains valid post-update. - Created test_update_price_refreshes_staleness.1.json to ensure updating price refreshes staleness correctly.
Owner
First quality code i've read all day |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #260