Conversation
yackermann
commented
Dec 9, 2020
yackermann
commented
- Fixed issue with Noble integration
- Moved to @abandonware/noble
- Fixed error with crashing when WinRT fails to return name
- Updated outdated libraries
- Other fixes
geovie
requested changes
Dec 12, 2020
Contributor
geovie
left a comment
geovie
left a comment
There was a problem hiding this comment.
Thanks a lot for this, the changes look reasonable. Two minor things then it's good from my side
Contributor
|
Need to get this merged as its the best version out there so far. Also would be nice to convert the code to work against the latest Windows 10 SDK. |
Author
|
@tony-gutierrez @geovie I've updated packages, and fixed specified issues. Appologies for the delay. |
|
+1 for getting this code merged. |
geovie
requested changes
Mar 27, 2022
Contributor
geovie
left a comment
geovie
left a comment
There was a problem hiding this comment.
LGTM except some places which will need a return statement.
Thanks again.
| auto& reader = DataReader::FromBuffer(value); | ||
| Data data(reader.UnconsumedBufferLength()); | ||
| reader.ReadBytes(data); | ||
| mEmit.Read(uuid, serviceId, characteristicId, data, false); |
Contributor
There was a problem hiding this comment.
Needs a return statement here else read will be emitted twice
| auto& reader = DataReader::FromBuffer(value); | ||
| Data data(reader.UnconsumedBufferLength()); | ||
| reader.ReadBytes(data); | ||
| mEmit.ReadValue(uuid, serviceId, characteristicId, descriptorId, data); |
| auto& reader = DataReader::FromBuffer(value); | ||
| Data data(reader.UnconsumedBufferLength()); | ||
| reader.ReadBytes(data); | ||
| mEmit.ReadHandle(uuid, handle, data); |
Contributor
|
Does look like some returns should be added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.