Actual and Set temperature for HK 3 fix for HPA-O 13 Premium#12
Open
arturzielazny wants to merge 4 commits intoThyMYthOS:masterfrom
Open
Actual and Set temperature for HK 3 fix for HPA-O 13 Premium#12arturzielazny wants to merge 4 commits intoThyMYthOS:masterfrom
arturzielazny wants to merge 4 commits intoThyMYthOS:masterfrom
Conversation
Running "mbpoll -m tcp -a 1 -t 3:int16 -r 609 -c 4 -1 192.168.0.178" on my pump gives: -- Polling slave 1... [609]: -32768 [610]: 220 [611]: 202 [612]: -32768 Which is consistent with the misreported data in my Home Assistant installation.
apparently temperature addresses (610 and 611) were in more places...
count changed to 111, becaue register 611 was not read correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running "mbpoll -m tcp -a 1 -t 3:int16 -r 609 -c 4 -1 192.168.0.178" on my pump gives:
-- Polling slave 1...
[609]: -32768
[610]: 220
[611]: 202
[612]: -32768
But the library uses 609 and 610 for the HK 3 actual and set temperature. My PR assumes that all the WPM pumps use the same addresses and updates them to the ones working with HPA-O 13. After this change, HK3 shows correctly in my Home Assistant.