templates: data-display: rename 'Beneficiary' to 'Grant Location' and change order #248
Conversation
BibianaC
force-pushed
the
bc/rename-beneficiary-to-grant-location
branch
4 times, most recently
from
9df3b3d to
40aea5f
Compare
Pull Request Test Coverage Report for Build 14125157530Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 14056323059Details
💛 - Coveralls |
|
@michaelwood @R2ZER0 Github test workflow coveralls failed with Python 3.8 but did not with 3.9. I decided to delete version 3.8 because the requirements are compiled with 3.10. |
michaelwood
left a comment
michaelwood
left a comment
There was a problem hiding this comment.
All looks good apart from the python version change.
.github/workflows/tests.yml
Outdated
| max-parallel: 4 | ||
| matrix: | ||
| python-version: [3.8, 3.9] | ||
| python-version: [3.9] |
There was a problem hiding this comment.
Can you explain this one? The live server uses python 3.8 so it's important we have parity with live for testing. Thanks
There was a problem hiding this comment.
@michaelwood Github test workflow coveralls failed with Python 3.8 but did not with 3.9. I decided to delete version 3.8 because the requirements are compiled with 3.10. I didn't see that the live server uses 3.8.
I can remove this change. I tried to fix coveralls, but I couldn't.
There was a problem hiding this comment.
I have added back Python 3.8. Before, it consistently failed coveralls with Python 3.8, and now it fails with 3.9.
BibianaC
force-pushed
the
bc/rename-beneficiary-to-grant-location
branch
from
041098e to
d94040a
Compare
Relates to #247