-
Notifications
You must be signed in to change notification settings - Fork 5
grantnav: frontend: Add the git version information to the about.html #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Don't forget to also update requirements_dev, that was missing from #1151 thanks |
I changed the requirements, not requirements_dev. Should I also change requirements_dev even if I haven't made any changes? @michaelwood |
|
@BibianaC Yes, please re-compile dev requirements too :) dev requirements include requirements ( https://github.com/ThreeSixtyGiving/grantnav/blob/live/requirements_dev.in#L1 ), so any changes to requirements will also change dev requirements. |
|
Thanks @R2ZER0 . I have re-compiled. |
requirements_dev.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| # | |||
| # This file is autogenerated by pip-compile with Python 3.8 | |||
| # This file is autogenerated by pip-compile with Python 3.12 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BibianaC Sorry last thing - please could you re-compile using Python 3.8 instead of Python 3.12 , so it's the same as requirements.txt https://github.com/ThreeSixtyGiving/grantnav/blob/live/requirements.txt#L2
... we'll get around to upgrading python one day soon :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@R2ZER0 sorry, I didn't realise about the version. Now it is with version 3.8.
957b2e1 to
6a7a574
Compare
6a7a574 to
c01fc97
Compare
michaelwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-based your branch and squashed the unnecessary commits however the git version is always "unknown", could you re-test this please and see if there is an issue.
Pull Request Test Coverage Report for Build 13944029291Details
💛 - Coveralls |
9d3d669 to
63b7726
Compare
|
@michaelwood @R2ZER0 it should be working now. |
Great thanks |
Steps 3, 4 & 5 of #801