Skip to content

Conversation

@BibianaC
Copy link
Member

@BibianaC BibianaC commented Mar 12, 2025

Steps 3, 4 & 5 of #801

@BibianaC BibianaC marked this pull request as draft March 12, 2025 10:24
@BibianaC BibianaC marked this pull request as ready for review March 13, 2025 09:04
@BibianaC BibianaC requested a review from michaelwood March 13, 2025 09:04
@michaelwood michaelwood requested a review from R2ZER0 March 13, 2025 11:05
@michaelwood
Copy link
Member

Don't forget to also update requirements_dev, that was missing from #1151 thanks

@BibianaC
Copy link
Member Author

Don't forget to also update requirements_dev, that was missing from #1151 thanks

I changed the requirements, not requirements_dev. Should I also change requirements_dev even if I haven't made any changes? @michaelwood

@R2ZER0
Copy link
Contributor

R2ZER0 commented Mar 13, 2025

@BibianaC Yes, please re-compile dev requirements too :)

dev requirements include requirements ( https://github.com/ThreeSixtyGiving/grantnav/blob/live/requirements_dev.in#L1 ), so any changes to requirements will also change dev requirements.

@BibianaC
Copy link
Member Author

Thanks @R2ZER0 . I have re-compiled.

@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.8
# This file is autogenerated by pip-compile with Python 3.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BibianaC Sorry last thing - please could you re-compile using Python 3.8 instead of Python 3.12 , so it's the same as requirements.txt https://github.com/ThreeSixtyGiving/grantnav/blob/live/requirements.txt#L2
... we'll get around to upgrading python one day soon :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@R2ZER0 sorry, I didn't realise about the version. Now it is with version 3.8.

@BibianaC BibianaC force-pushed the bc/git-version-info-about branch from 957b2e1 to 6a7a574 Compare March 18, 2025 09:26
@michaelwood michaelwood force-pushed the bc/git-version-info-about branch from 6a7a574 to c01fc97 Compare March 18, 2025 18:25
Copy link
Member

@michaelwood michaelwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-based your branch and squashed the unnecessary commits however the git version is always "unknown", could you re-test this please and see if there is an issue.

@coveralls
Copy link

coveralls commented Mar 18, 2025

Pull Request Test Coverage Report for Build 13944029291

Details

  • 5 of 7 (71.43%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 63.102%

Changes Missing Coverage Covered Lines Changed/Added Lines %
grantnav/utils.py 4 6 66.67%
Totals Coverage Status
Change from base Build 13943276571: 0.03%
Covered Lines: 1428
Relevant Lines: 2263

💛 - Coveralls

@BibianaC BibianaC force-pushed the bc/git-version-info-about branch from 9d3d669 to 63b7726 Compare March 19, 2025 10:13
@BibianaC
Copy link
Member Author

@michaelwood @R2ZER0 it should be working now.

@michaelwood
Copy link
Member

@michaelwood @R2ZER0 it should be working now.

Great thanks

@michaelwood michaelwood merged commit 67867d3 into live Mar 19, 2025
6 checks passed
@michaelwood michaelwood deleted the bc/git-version-info-about branch March 19, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants