templates: Update all instances of urls to go to new website structure #1147
Conversation
codemacabre
left a comment
codemacabre
left a comment
There was a problem hiding this comment.
Looks good, although there are a few links with a title attribute which seem superfluous. According to WCAG, links should only contain title attributes to provide supplementary information. Duplication of text in the link text means anyone using a screen reader will hear the text twice, which isn't good practice.
I recommend reviewing the title texts and deciding whether they're providing any useful supplementary information.
Thanks, my rationale was that product names aren't descriptive so my hope was to add accessibility to those links. |
gnu.org drops requests occasionally which is possibly due to them coming from github's infrastructure. Skip testing the license link.
mariongalley
left a comment
mariongalley
left a comment
There was a problem hiding this comment.
Added 3 comments on specific files - hopefully this process makes them discoverable
There was a problem hiding this comment.
We're not intending to publicly share the link to the unstyled Registry 'classic'. The options are to either refer to the Registry without providing a link (it's now an internal tool), which is the approach we've taken in the Publisher Guidance, or provide the link to the Quality Dashboard where signposting to a link of all publishers. I think in this case we should do the former.
There was a problem hiding this comment.
Correct link for negative/zero values guidance is https://www.360giving.org/explore/before-you-start/what-to-look-for/#negative-zero
There was a problem hiding this comment.
Best link for GrantNav workshops is https://www.360giving.org/support/?event_type%5B%5D=intro-to-grantnav&sort-by=date
michaelwood
force-pushed
the
mw/update_links_new_website
branch
2 times, most recently
from
855a285 to
94ddd0c
Compare
michaelwood
force-pushed
the
mw/update_links_new_website
branch
from
94ddd0c to
9c07cc4
Compare
No description provided.