Skip to content

Mw/update tools for new lib #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelwood wants to merge 2 commits into from
Closed

Mw/update tools for new lib #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f74f55
tools: coverage360: Add required data dir parameter
michaelwood May 22, 2025
430cf3a
tools: cove_checks: Update for new lib360dataquality version
michaelwood May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions tools/cove_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@

from lib360dataquality.cove.threesixtygiving import (
common_checks_360,
USEFULNESS_TEST_CLASS,
QUALITY_TEST_CLASS,
)
from lib360dataquality.additional_test import TestType
from lib360dataquality.cove.settings import COVE_CONFIG
from lib360dataquality.cove.schema import Schema360

Expand Down Expand Up @@ -49,7 +48,7 @@ def main():
file_type = args.file_type
# TODO Just dealing with one at a time
file_path = args.file_path[0]
schema = Schema360()
schema = Schema360(working_dir)

if not file_type:
file_type = os.path.splitext(file_path)[1][1:].lower()
Expand Down Expand Up @@ -78,11 +77,11 @@ def main():

if args.usefulness_only and not args.quality_only:
common_checks_360(
context, working_dir, data, schema, test_classes=[USEFULNESS_TEST_CLASS]
context, working_dir, data, schema, test_classes=[TestType.USEFULNESS_TEST_CLASS]
)
elif args.quality_only and not args.usefulness_only:
common_checks_360(
context, working_dir, data, schema, test_classes=[QUALITY_TEST_CLASS]
context, working_dir, data, schema, test_classes=[TestType.QUALITY_TEST_CLASS]
)
else:
common_checks_360(context, working_dir, data, schema)
Expand Down
2 changes: 1 addition & 1 deletion tools/coverage360.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
data_all = json.load(open('data/status.json'))
stats = []

schema_obj = Schema360()
schema_obj = Schema360("data")
schema_fields = schema_obj.get_pkg_schema_fields()


Expand Down