Skip to content

Support local schema files #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelwood merged 1 commit into from
Apr 17, 2025
Merged

Support local schema files #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions lib360dataquality/cove/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class Schema360(SchemaJsonMixin):
_pkg_schema_obj = {}
_schema_obj = {}

def __init__(self, data_dir) -> None:
def __init__(self, data_dir, local_pkg_schema_path=None, local_grant_schema_path=None) -> None:
# Create dedicated location for schema work
self.working_dir = os.path.join(data_dir, "schema")
try:
Expand All @@ -40,11 +40,19 @@ def __init__(self, data_dir) -> None:
# urljoin does not discard the final part of the location.
self.schema_host = f"{self.working_dir}/"

schema_url = urljoin(config["schema_host"], self.schema_name)
pkg_schema_url = urljoin(config["schema_host"], self.pkg_schema_name)

self._pkg_schema_obj = get_request(pkg_schema_url).json()
self._schema_obj = get_request(schema_url).json()
if local_pkg_schema_path:
with open(local_pkg_schema_path) as f:
self._pkg_schema_obj = json.load(f)
else:
pkg_schema_url = urljoin(config["schema_host"], self.pkg_schema_name)
self._pkg_schema_obj = get_request(pkg_schema_url).json()

if local_grant_schema_path:
with open(local_grant_schema_path) as f:
self._schema_obj = json.load(f)
else:
schema_url = urljoin(config["schema_host"], self.schema_name)
self._schema_obj = get_request(schema_url).json()

# Update the pkg schema to no longer point to an external reference for the
# grants schema.
Expand Down