Mw/upgrade django #142
Merged
Mw/upgrade django #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelwood
force-pushed
the
mw/upgrade_django
branch
2 times, most recently
from
d2ab73f to
dab22c5
Compare
This is for the django upgrade for the python 3.12 upgrade
This also makes the variable consistent between views for "pk" vs "id" and fixes the gettext import for the new version.
Make sure that the urls and the tests are in sync (trailing slash has been removed)
Make this test only a valid uuid which doesn't exist. We now use <uuid> in the path definition (urls.py) which means a non-uuid will cause a 404, rather than information about the results not being available.
michaelwood
force-pushed
the
mw/upgrade_django
branch
from
dab22c5 to
bad2662
Compare
michaelwood
force-pushed
the
mw/upgrade_django
branch
from
bad2662 to
ab333dd
Compare
Fixes new warning about shadowed cove_tags (from lib-cove-web) `Warning: ?: (templates.E003) 'cove_tags' is used for multiple template tag modules: 'cove.templatetags.cove_tags', 'cove_360.templatetags.cove_tags'`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.