Added code to take AWS credentials from environment variables#93
Open
qutorial wants to merge 1 commit intoThreatResponse:masterfrom
Open
Added code to take AWS credentials from environment variables#93qutorial wants to merge 1 commit intoThreatResponse:masterfrom
qutorial wants to merge 1 commit intoThreatResponse:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is helpful to most of the users who use credentials in the environment variables.
export AWS_ACCESS_KEY_ID=aaa
export AWS_SECRET_ACCESS_KEY=bbb
export AWS_SESSION_TOKEN=ccc
It covers a feature request for it (can't find it now, sorry), and make life of users easier
in this case by making aws_ir behave in a similar way like other standard and known
CLI tools for AWS: aws cli, cdk, ...
I am open for your comments!