Support for SIGV4-only AWS regions#4
Open
bitterblue wants to merge 2 commits intoThoughtWorksInc:masterfrom
Open
Support for SIGV4-only AWS regions#4bitterblue wants to merge 2 commits intoThoughtWorksInc:masterfrom
bitterblue wants to merge 2 commits intoThoughtWorksInc:masterfrom
Conversation
added 2 commits
March 27, 2016 12:36
To synchronize with S3 buckets in regions that only support Signature Version 4, SIGV4 has to be enabled in the client library via a system property (see http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingAWSSDK.html) and requests have to be directed against an endpoint in that region. This patch allows specifying an endpoint in the Leiningen project file. If an endpoint is set, SIGV4 is automatically enabled.
|
Any reason this hasn't been accepted? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm using your plugin to deploy a static website to an S3 bucket in Frankfurt. I had to make a small extension, because Frankfurt is one of the newer regions that only support AWS Signature Version 4. Is this still interesting to you?
Thanks :)