Vote Command Improvements #751
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… redis upgrades; legacycommandparser upgrades; and add vote slash command
Renamed voteConfiguration to voteConfig Added documentation within vote.js Added feedback type identification and filtering IN PROGRESS Reworking vote setup interactions
work in progress
finalize changes before draft PR
4 tasks
debugging vote progression
tro2
force-pushed
the
Trodaire/filtering-vote-feedbacks
branch
from
4cf49fe to
60729d3
Compare
Fixed up display of votes, added functionality to add and remove votes from included list
Contributor
Author
|
Ready for review |
Changed args to list of users Fixed a bug with failing to add feedbacks when list length is 0 Changed display of votes to use emojis
ghost
suggested changes
Feb 23, 2024
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Most of these are nitpicks but there are a couple small things that do need addressing first.
changed votesetup from class to an object with typedef improved documentation altered display of unidentified dungeon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViBot [X.X.X]
Changelog
Features
Changes
Quality of Life
Summary
Overview