ViBotChannels and RoleAssignment Refactor #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed roleAssignment.js and vibotChannels.js from ESLint + roleAssignment.js now has a slash command variant + roleAssignment.js now restarts bot listeners + roleAssignment.js had code structure modernised + botSetup.js now references roleAssignment.js
+ roleAssignment.js, roleAssignment.json now references bot.storedEmojis
2 tasks
Ragviswa
added
Shatters/Moonlight
Contributor
Huntifer-RotMG
left a comment
Huntifer-RotMG
left a comment
There was a problem hiding this comment.
Not a detailed review, just a quick glance -- consider using restart safe interactions though instead of adding listeners on startup.
- botSetup.js no longer references roleassignment.js + redis.js now works with component rows + pop.js uses component rows with redis.js + roleassignment uses redis.js with interactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViBot
Changelog
Changes
;roleassignmenthas a new sub-command for updating listeners;roleassignmentlistener restarting has been moved to roleassignment.js;roleassignment,vibotChannelsremoved from.eslintignorevibotChannelshas been removedQuality of Life
;roleassignmentnow referencesbot.storedEmojis;roleassignmentnow supports a slash command variantSummary
Examples