Husky/headcount rework

[ghost]

ViBot

Changelog

Features

Complete Headcount rewrite

• Added headcount as a slash command /hc <type> [length] [duration]
  • type is autocomplete and will provide a list of matching templates you can run in the channel
    • If they use the alias anyways instead of a full number, it will still match it
  • duration is autocomplete for Seconds Minutes and Hours, also accepts partial text
• Asks to confirm sending headcount if there are active headcounts matching certain criteria
  • 2 or more active headcounts already in the relative status channel
  • Any active headcount in the relative status channel using the same template
  • Any active headcount the leader has up in the server
  • Any active AFK checks in the relative status channel
• Added commands channel panel if headcount was provided timeout options
  • No panel if used plainly ;hc v since cannot clarify when it should stop sending items over
    • If maybe it should default to some time so they all have a panel, that might be good too but I opted out of that for now (easy to change)
  • Displays short lists of reacts, who reacted to key, etc.
  • Has two buttons 'Convert to AFK' and 'Abort'
  • Convert to AFK - Attempts to process an afk check from a headcount panel
    • Will pop up with a modal asking for location, unsure if this should instead be requested in chat, easy to change
    • Then, processes an afk check as if you ran ;afk <type> <location>

Changes

.eslintignore

• removed commands/headcount.js

botSetup.js

• Added headcount initialization

commands/afkCheck.js

• Added class afkCheck in module.exports
• Added leader = message.member argument to afkCheck.ctor to provide a different GuildMember than what's attached to the message argument for headcount conversion.
• Added panelReply parameter to afkCheck.start to provide a message to reply to instead of only sending it in commands channel (for headcount conversion)
• Added replyTo parameter for afkCheck.sendInitialStatusMessage to provide a message to reply to instead of only sending it in status channel (for headcount conversion)
• Added many JSDoc comments for better Intellisense typings

commands/afkTemplate.js

• Provided a getter for the underlying template (used to serialize headcounts & avoid mismatching with an updated template on restart)
• Updated #validateTemplateEmote and #processReacts to consider if the template provided has previously ran #processReacts (this happens when loading one from redis)
• Added AfkTemplate.getRandomThumbnail() to return a random thumbnail from the body
• Added many JSDoc comments for better Intellisense typings
• Added getter for AfkTemplate.#template
  commands/templates.js
• For testing bots who might not be in all emote servers, add a null chain on bot.storedEmojis[...].text in case the emoji wasn't loaded

index.js

• Calls handleHeadcountRow if handleReactionRow returns false to check if it's a headcount reaction

commands/templates.js

• Add null-chain for testing bots that might not have all emojis loaded.

commands/headcount.js

• Completely rewritten, functional changes described under Features

Bugs

• Should stop headcounts with the timeout argument from causing rate limits

Quality of Life

• Various JSDoc additions
• Convert to Afk button for headcounts
• Confirm to not contest other headcounts

Examples

/hc 'Ocean Trench' 5 Minutes

Commands Channel panel

Status Channel message

Aborted Headcount panel

/hc 'v' - headcount with no timeout given

Confirmation if existing headcount from leader

Cancel confirmation

Commands Channel panel

Status Channel message

*hc so 2 m

Converted Headcount asks for location

Headcount panel & afk panel

Raid status channel

*hc v 2 m with a void headcount + 1 in rsa and +1 in vet status

with an active afk check

[ghost]

This is now fully ready for review after considerations mentioned in #dev-lounge

[Huntifer-RotMG]

Not a detailed review, will try and write more later but I would strongly prefer if we didn't add hundreds of lines of (questionably valid JSDoc)