This repository was archived by the owner on Jun 28, 2023. It is now read-only.
Open
Conversation
|
Hey @SKPunkt, thanks a lot for this PR. I'm very sorry that I didn't respond earlier. I didn't see the PR (must have missed the email notification) and just discovered it now because I wanted to continue some development on this library. Your improvements look great. I'll have a more detailed look and do some tests probably next week. One question already: Is there a reason why you didn't use the existing Python ISO-TP library, but implemented it yourself? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
i wanted to read out the individual cell voltages and implemented a very simple request/response mechanism. Then it got a little more ;-)
I hope it's not to big for a pull request or i can split it up a bit.
packet.pycansocket.pythingset_can.pythingset_log.pyReadme.mdtest.py