-
Notifications
You must be signed in to change notification settings - Fork 25
Add Dockerfile #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pferreir
wants to merge
1
commit into
ThiefMaster:master
Choose a base branch
from
pferreir:add-dockerfile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Dockerfile #59
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| FROM python:3.13-alpine | ||
|
|
||
| RUN apk add --update apache2-utils bash | ||
| RUN python -m venv /maildump | ||
| RUN /maildump/bin/pip install maildump | ||
|
|
||
| ENV MAILDUMP_PASSWORD= | ||
| ENV MAILDUMP_HTTP_IP=0.0.0.0 | ||
| ENV MAILDUMP_HTTP_PORT=1080 | ||
| ENV MAILDUMP_SMTP_IP=0.0.0.0 | ||
| ENV MAILDUMP_SMTP_PORT=1025 | ||
|
|
||
| ADD docker/entrypoint.sh / | ||
| RUN mkdir /maildump/data | ||
| RUN chown 1000 /maildump/data | ||
|
|
||
| USER 1000 | ||
|
|
||
| ENTRYPOINT ["/entrypoint.sh"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| #!/bin/bash | ||
|
|
||
| ARGS="--http-ip ${MAILDUMP_HTTP_IP} \ | ||
| --http-port ${MAILDUMP_HTTP_PORT} \ | ||
| --smtp-ip ${MAILDUMP_SMTP_IP} \ | ||
| --smtp-port ${MAILDUMP_SMTP_PORT} \ | ||
| -f" | ||
|
|
||
| PASSWORD_FILE=/maildump/data/passwd | ||
|
|
||
| if [[ ! -z $MAILDUMP_PASSWORD ]]; then | ||
| htpasswd -bc $PASSWORD_FILE maildump $MAILDUMP_PASSWORD; | ||
| /maildump/bin/maildump ${ARGS} --htpasswd $PASSWORD_FILE; | ||
| else | ||
| /maildump/bin/maildump ${ARGS} | ||
| fi |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd create and use an unprivileged users for this, no need to run maildump as root inside the container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right. I usually use podman for this sort of stuff, which is fully user space. Not sure if I can make it work with both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.e. I cannot have a Dockerfile do useradd if I want it to run on podman. What I think I could do is to set UID=1000...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(done)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just needed for the build, isn't it? so if I publish an image to docker hub / ghcr, you should be able to run it in any case, right?
but indeed, something like
USER nobodyshould be sufficient, because it does not need to write anything (besides the htpasswd file, but you can just put that in a place like /tmp or make the directory world-writable)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point. It would still run on podman, it just wouldn't be built on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be fine like this... but maybe it should be tested with docker build. Works fine with podman.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed, it works on docker too.