A couple improvements - Improved precision, custom intermediate buffers, custom sampling#3
Open
ActuallyaDeviloper wants to merge 6 commits intoThemaister:masterfrom
Open
Conversation
…nal buffers and avoid unnecessary GPU memory usage.
… half precision for intermediate results nobody asked for. This introduces rounding errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this project is still maintained, but I want to contribute my changes back.
My changes are grouped into multiple commits.I thought about doing multiple PRs but that seemed more complicated so I decided to group everything here instead. The changes are basically:
fp16option.I am happy to make adjustments if you have any concerns regarding the changes. I ran the shortend version of the test program.