Potential fix for code scanning alert no. 3: Clear text transmission of sensitive cookie #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of sensitive cookie Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Ushcode
commented
Apr 25, 2025
Member
Author
Ushcode
left a comment
Ushcode
left a comment
There was a problem hiding this comment.
- NB this is a breaking change for deployments. It is now necessary to generate a unique SESSION_SECRET variable on the server before a production deployment with keycloak. See auth section of the main docs for guidance.
- Address security vulnerability 3
- Address security vulnerability 5
Ushcode
force-pushed
the
alert-autofix-3
branch
from
aef42c3 to
95b2be4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/TheWorldAvatar/viz/security/code-scanning/3
To fix the problem, we need to ensure that the session cookie is only transmitted over secure connections by setting the
secureattribute totrue. This can be done by modifying the session configuration to include thesecureattribute. Additionally, we should set thehttpOnlyattribute to prevent client-side scripts from accessing the cookie, further enhancing security.server.use(session({...block to include thesecureandhttpOnlyattributes.secureattribute is conditionally set based on the environment (e.g., only set totruein production).Suggested fixes powered by Copilot Autofix. Review carefully before merging.