Skip to content

Fixed logic bug in version.dll check #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheTrueColonel merged 1 commit into from
Feb 25, 2026
Merged

Fixed logic bug in version.dll check #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ShinRyuModManager-CE/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ private static async Task MainCli(string[] args) {
Log.Information("Shin Ryu Mod Manager-CE v{Version}", AssemblyVersion.GetVersion());
Log.Information("By TheTrueColonel (a port of SRMM Studio's work)");

HandleLoader();

// Parse arguments
var list = new List<string>(args);

Expand Down Expand Up @@ -415,7 +413,7 @@ private static List<ModInfo> ScanMods(ProfileMask activeProfiles = ProfileMask.A
}

internal static bool MissingDll() {
return File.Exists(Constants.VERSIONDLL) || File.Exists(Constants.DINPUT8DLL);
return !File.Exists(Constants.VERSIONDLL) && !File.Exists(Constants.DINPUT8DLL);
}

internal static bool MissingAsi() {
Expand Down
2 changes: 1 addition & 1 deletion ShinRyuModManager-CE/ShinRyuModManager-CE.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<AvaloniaUseCompiledBindingsByDefault>true</AvaloniaUseCompiledBindingsByDefault>

<!-- Versioning -->
<AssemblyVersion>1.4.9</AssemblyVersion>
<AssemblyVersion>1.4.10</AssemblyVersion>
<VersionPrefix>$(AssemblyVersion)</VersionPrefix>
<AssemblyTitle>ShinRyuModManager-CE</AssemblyTitle>
<Company>SRMM Studio</Company>
Expand Down
8 changes: 7 additions & 1 deletion ShinRyuModManager-CE/UserInterface/Assets/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
> ### **%{color:gold} Version 1.4.9 %** ###
> ### **%{color:gold} Version 1.4.10 %** ###
* Fixed logic bug in check for Version.dll
* Massive improvements in memory usage for CPK repacking

---

> ### **%{color:orange} Version 1.4.9 %** ###
* Implemented changes from SRMM 4.8.2 (Fixed mods not loading for Yakuza 6 and earlier)
* Windows 11 just wants to be complicated

Expand Down