Open
Conversation
Switched renzoku from using yaml based configs to libconfig instead. libconfig is much more in line with the type of config that I was hoping to have renzoku use in the first place. Now that I have finally decided on an official config format, I can finally start actually recommending it's use to others since renzoku should be able to build on other OSs. It used to be that only Linux Distros with the latest and greatest packages could do so. This fixes #2 and gets a closer to completing the tasks needed for #1. Signed-off-by: Colton Wolkins (Ogre) <frostyfrog2@gmail.com>
When a process' command was NULL (Not set), or when it was disabled, we were still trying to for and run the command. Now we return false.
Detailed Reasoning ================== Fed Up ------ I'm fed up with the configuration parsers out there. The versions that are out there that I've used in this project so far (libconfig++ and libyaml-cpp) have changed their API in some way or another that made it impossible to compile on older systems, without shipping the libraries along with the package or statically linking them into renzoku. Birth of a Parser ----------------- I have started to write my own parser so that I A) achieve better cross-platformify renzoku and B) finally learn how to write a parser from the ground up. The code within this commit is still in-development and will be until it can successfully parse the config file outlined in GH-3. Problems with the previous config format ---------------------------------------- Quite frankly, the main problem with the previous config file format was that I was unable to step away from the project and think of other use cases. The only main use cases that I had were my own. Speaking about Renzoku at PLUG really helped me understand how renzoku could be used by other people. GH-3 came out of PLUG and has become more of a guide for where I'm heading next with my code. :D
This is the first pass at my official parser. It isn't complete, it's not near complete, but it works well so far. I'm creating and pushing this commit as a checkpoint since I'm currently at 801Labs and I want to make sure that I have a backup somewhere. :) Never know what hacktivists might do ;p
Now parsing watcher blocks and initial configuration options. Not currently saving options or parsing steps. That is what I'll be working on next.
I fixed the parser code so that: A) It works (for the most part) and, B) It's easy to use and attach to the main renzoku application. This is me working towards #2
On a side note: 1) it works! 😳 2) I can now semi use renzoku for development again 😁 Now... To get it to be more production level and working somewhat decently. 😅
This should fix #2 as far as CentOS 7 goes. Have not tested on CentOS 6 or on Debian. Those are the next goals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.