Add combat minigame #73
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rj-lee
commented
Sep 6, 2023
rj-lee
commented
- Split actions.py into separate files, it was getting massive
- I don't 100% like all the code here, it's getting more complicated so if we have another major feature this is due for a refactor to split things up
- A main issue with the current state of the minigame is that you can start towards the end of the duration and score 100% on just the last arrow, I'm not sure what's the best way to handle that
- I have another idea once the above issue is fixed, what if scoring 100% gave you a much bigger bonus, such as insta-wiping the enemy army? We can of course make the game much harder to score perfectly or reduce the bonus
TheRedPanda17
force-pushed
the
rj/mining-army-sidebar
branch
2 times, most recently
from
ce8e9a7 to
999a3b3
Compare
rj-lee
force-pushed
the
rj/combat-minigame
branch
2 times, most recently
from
36fe7a0 to
10af339
Compare
TheRedPanda17
force-pushed
the
rj/combat-minigame
branch
from
10af339 to
76ab7fc
Compare
Owner
|
For feature parity, the number of keys should change between 3-4. |
TheRedPanda17
requested changes
Sep 8, 2023
Collaborator
Author
|
While testing I realized that a textual version later than 0.32.0 made minigames really laggy, so that's something to note when considering upgrading dependencies in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.