Data package handling improvements#230
Open
DrAwesome4333 wants to merge 5 commits intoThePhar:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is provided as a suggestion to improve data package handling. I have put these to use in my fork of archipelago.js and have had good results. This PR should help reduce the initial stress that clients using archipelago.js put on the Archipelago servers they connect to.
This PR does the following:
DataPackageCachethat can be supplied by the using application to allow archipelago.js to request specific game packages rather than having the using application supply all data packages at once. Example Implentation.toSorted()requires ES 2023 and above.