Improve color contrast of the fail/pass icon #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 29, 2024 00:06
- **Menu** :
- "Move to previous monitor" -> "이전 모니터로 옮기기"
- "Move to next monitor" -> "다음 모니터로 옮기기"
- **Main** :
- "Version {version} is available" -> {version} 버전을 사용할 수
있습니다."
- "More Details" -> "상세 내역 보기"
- "Download" -> "다운로드"
- "Close" -> "닫기"
- **About**
- Under -> "라이선스"
The contrast mode issue(ThePacielloGroup#355, ThePacielloGroup#356) prompted me to revisit the color contrast of the CCA user interface. I identified issues with color contrast across various screen theme modes (e.g., Windows Contrast Theme, Dark Mode, Light Mode), particularly with the fail (X mark) and pass (check mark) icons. To address this, I adjusted the colors to ensure a contrast ratio of at least 4.5:1 in all modes (Light, Dark, and Contrast Mode).
Contributor
Author
|
@ferllings I solved the merge conflicts with global.css |
Contributor
|
@ungjinPark Thanks, I'll review it |
This reverts commit 128b7a5.
Contributor
|
It looks like we are loosing some text, in dark mode: |
Contributor
Author
|
I forgot these icons. I fix it on html. They no longer use '.svg' background image. And I fixed "absolute" positioned layouts. Also I tried to fix it to look as similar to the previous version as possible. |
|
How is this going along? @ferllings @ungjinPark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contrast mode issue(#355, #356) prompted me to revisit the color contrast of the CCA user interface.
I identified issues with color contrast across various screen theme modes (e.g., Windows Contrast Theme, Dark Mode, Light Mode), particularly with the fail (X mark) and pass (check mark) icons.
To address this, I adjusted the colors to ensure a contrast ratio of at least 4.5:1 in all modes (Light, Dark, and Contrast Mode).
Samples
The images below are samples with new colors applied.
Light Mode
Dark mode
Windows Contrast Themes
Night Sky
Desert
Aquatic
Dusk
Note
A converted text icon was added using the Icomoon library to help the icon support the system color of the contrast theme.