update workflows and magnum #313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The changes to the github actions files look great. What is the specific commit or tag you updated the magnum dependency(s) to? github doesn't make obvious. Ideally would be to update to a specific named release, if one exists. But otherwise "latest" is acceptable. |
Contributor
Author
|
Yeah for the updated packages, there haven't been new tags/releases in around 5-6 years corrade@c123ee86487da662e937c1ff7e393b889f90c7f7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of simple things.
Updates workflows to have non-deprecated images and bring in the new ones, as stated in #311.
Also, updates corrade, magnum, and magnum-plugins to latest (as of Dec. 12) in order to fix compilation on macOS.