Skip to content

Conversation

@TheMysteriousStranger90
Copy link
Owner

Dev branch harabadzhyu3

interface improvements and connection check optimization

  • added style for status bar (TextBlock.StatusBar) with font size 12px
  • optimized double checks for microphone and internet connection
  • detected issue with hardcoded language "en-US" in TranscriptionViewModel
  • suggested solution to use language settings from SettingsViewModel

- added style for status bar (TextBlock.StatusBar) with font size 12px
- optimized double checks for microphone and internet connection
- detected issue with hardcoded language "en-US" in TranscriptionViewModel
- suggested solution to use language settings from SettingsViewModel
Copilot AI review requested due to automatic review settings July 8, 2025 04:26
@TheMysteriousStranger90 TheMysteriousStranger90 merged commit 9dc9ede into master Jul 8, 2025
2 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the UI styling, externalizes hardcoded language settings, and removes redundant connectivity checks.

  • Adds a SourceForge download badge in README.
  • Refactors TranscriptionViewModel to use ISettingsService for language and comments out double-check logic.
  • Removes periodic microphone/internet checks in MainWindowViewModel and adds a new style for status bar text.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
README.md Added SourceForge download link
Views/TranscriptionView.axaml Removed tooltip attributes and recording-pulse class on Ellipse
Views/SettingsView.axaml Shortened audio note description
ViewModels/TranscriptionViewModel.cs Injected ISettingsService, replaced hardcoded language, commented out redundant checks
ViewModels/MainWindowViewModel.cs Commented out periodic microphone and internet check blocks
Styles/Styles.axaml Defined TextBlock.StatusBar style for status bar text
AzureSpeechProject.csproj Bumped assembly, file, and informational versions to 1.1.1.0
Comments suppressed due to low confidence (4)

AzureSpeechProject/ViewModels/MainWindowViewModel.cs:64

  • The periodic microphone and internet check logic is commented out; if intentional deprecation is complete, remove these blocks to simplify the codebase.
                        .DisposeWith(disposables);

AzureSpeechProject/ViewModels/TranscriptionViewModel.cs:158

  • New behavior loads language from settings; add unit tests to verify correct SpeechLanguage is passed into TranscriptionOptions.
            var settings = await _settingsService.LoadSettingsAsync();

AzureSpeechProject/Views/TranscriptionView.axaml:91

  • Removing the tooltip may reduce discoverability for keyboard and screen reader users; consider retaining or replacing the ToolTip.Tip for accessibility.
            <Button Command="{Binding ClearCommand}" IsEnabled="{Binding CanClear}" Classes="action secondary">

AzureSpeechProject/Views/TranscriptionView.axaml:108

  • The recording-pulse class was removed; if the pulsing animation is no longer needed, consider deleting related styles or tests, otherwise restore the class to maintain visual feedback.
                <Ellipse Width="16" Height="16" Fill="{DynamicResource AzureRed}" />


try
{
/*
Copy link

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large commented-out blocks of legacy network and microphone checks make the method harder to read; consider removing them or extracting into a feature flag.

Copilot uses AI. Check for mistakes.
@TheMysteriousStranger90 TheMysteriousStranger90 deleted the dev_branch_harabadzhyu3 branch July 8, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants