Add search pattern to compare items against the character's average item level#58
Open
shrugal wants to merge 3 commits intoTheMouseNest:mainfrom
Open
Add search pattern to compare items against the character's average item level#58shrugal wants to merge 3 commits intoTheMouseNest:mainfrom
shrugal wants to merge 3 commits intoTheMouseNest:mainfrom
Conversation
shrugal
force-pushed
the
main
branch
2 times, most recently
from
7ec2ea8 to
c11e3be
Compare
Author
|
Heyho, any chance for this to get merged? |
shrugal
force-pushed
the
main
branch
2 times, most recently
from
b41bca4 to
2b1b02c
Compare
shrugal
force-pushed
the
main
branch
2 times, most recently
from
3c454d1 to
7e7e236
Compare
shrugal
force-pushed
the
main
branch
2 times, most recently
from
c416d80 to
ff7b533
Compare
shrugal
force-pushed
the
main
branch
3 times, most recently
from
ea1c357 to
5fbb1ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the required changes for TheMouseNest/Baganator#347, adding a search pattern to filter items with queries like
>avgilvl(above average item level) or<avgilvl-30(more than 30 levels below average item level).Edit: I also added a pattern to compare against the character's max slot ilvl (e.g.
<slotilvl-26), since the average can vary a lot between slots. The slot ilvl is updated on bag/bank/equipped cache updates.