Message & timestamp padding + leading tab alignment#165
Open
mitchtreece wants to merge 6 commits intoTheMouseNest:mainfrom
Open
Message & timestamp padding + leading tab alignment#165mitchtreece wants to merge 6 commits intoTheMouseNest:mainfrom
mitchtreece wants to merge 6 commits intoTheMouseNest:mainfrom
Conversation
Author
|
@plusmouse Let me know if there’s any edits you’d like me to make to this 😄 |
… -> inset_edge_tabs
Added options for tab spacing, dynamic tab sizing + align_leading_tabs -> inset_edge_tabs
# Conflicts: # Core/Messages.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💬 Summary
Love this addon - literally saved me the time of writing my own. Missing a couple minor things that bug me, so added them here 😄 This PR contains the following changes:
Tab Spacing
Added a new layout option to customize the spacing between tabs.
Dynamic Tab Sizing
Added a new layout option that dynamically sizes tabs, taking up all available horizontal space (minus tab spacing).
Inset Edge Tabs
Added a new layout option that controls the leading/trailing tab's alignment. Currently, the leading tab does not sit flush with the chat box's edge. This option now lets you control this.
Message Padding
Added a new layout option that controls a message's padding (x-offset) from the chat box's leading edge.
Timestamp Padding
Added a new layout option that controls a message's padding (x-offset) from its timestamp. This also updates how the timestamp separator's position is calculated, so it can dynamically update when its padding is updated.