SOD: Alchemy crafting procs#1671
Open
Untitled-WOW wants to merge 1 commit intoTheMouseNest:masterfrom
Open
Conversation
Logic added to display profit margins for x2 procs in SOD for Alchemy crafting procs.
Member
|
There's a couple of issues:
|
|
Hi @Untitled-WORS This winter i did something similar, but never opened a pull request Here what i did: https://github.com/etkr/Auctionator From testing i also found the mixilogy proc rate to be consistently about 2.1 And i noticed that Frost oil and Shadow oil don't have procs so they need to be exluded explicitly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic added to display profit margins for x2 procs in SOD for Alchemy crafts.
Currently using completion of quest id 82090 to verify user is in SOD version of game and have completed required quest to recieve procs.
This could be implimented for Tailoring / Leatherworking cooldown crafts but i couldnt find a way to better tell when a user is in SOD or Era.