Tooltip: Implemented setting to hide the default "Sell Price" tooltip#1455
Open
simonebarbieri wants to merge 2 commits intoTheMouseNest:masterfrom
Open
Tooltip: Implemented setting to hide the default "Sell Price" tooltip#1455simonebarbieri wants to merge 2 commits intoTheMouseNest:masterfrom
simonebarbieri wants to merge 2 commits intoTheMouseNest:masterfrom
Conversation
Member
|
This feature was in retail Auctionator by default, but removed after it appeared to cause blocked actions in combat. |
Author
|
Oh, sorry, I didn't know that :) I understand if you want to close this PR if you don't want to risk it adding it back :) I'll just keep it as separate addon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new setting, in the Tooltip section, to hide the Blizzard default tooltip "Sell Price". This is because Auctionator offers the same information with the label "Vendor".
In my opinion the setting could be completely removed, because, again, the information is basically duplicated if you enabled the vendor tooltip, but I've implemented it just in case you prefer to give the option to keep it.
Translation lines for other languages are missing, sorry. I wanted to avoid using automated tools.
I've tested only in retail though, I'm not sure this would work in Classic.