Open
Conversation
Contributor
|
RSI Diff Bot; head commit bc4ebb4 merging into 39dd32f Resources/Textures/_Maid/Clothing/Hands/Gloves/Color/yellow.rsi
Resources/Textures/_Maid/Clothing/Head/Hardsuits/ERThelmets/ertengineer.rsi
Resources/Textures/_Maid/Clothing/Head/Hardsuits/ERThelmets/ertjanitor.rsi
Resources/Textures/_Maid/Clothing/Head/Hardsuits/ERThelmets/ertleader.rsi
Resources/Textures/_Maid/Clothing/Head/Hardsuits/ERThelmets/ertmedical.rsi
Resources/Textures/_Maid/Clothing/Head/Hardsuits/ERThelmets/ertsecurity.rsi
Resources/Textures/_Maid/Clothing/Head/Hats/warden.rsi
Resources/Textures/_Maid/Clothing/OuterClothing/Coats/labcoat_chem.rsi
Resources/Textures/_Maid/Clothing/OuterClothing/Hardsuits/ERTSuits/ertengineer.rsi
Resources/Textures/_Maid/Clothing/OuterClothing/Hardsuits/ERTSuits/ertjanitor.rsi
Resources/Textures/_Maid/Clothing/OuterClothing/Hardsuits/ERTSuits/ertleader.rsi
Resources/Textures/_Maid/Clothing/OuterClothing/Hardsuits/ERTSuits/ertmedical.rsi
Resources/Textures/_Maid/Clothing/OuterClothing/Hardsuits/ERTSuits/ertsecurity.rsi
Resources/Textures/_Maid/Clothing/Shoes/Specific/galoshes.rsi
Resources/Textures/_Maid/Objects/Devices/encryption_keys.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/clusterbang.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/clusterbomb.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/empgrenade.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/flashbang.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/grenade.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/holyhandgrenade.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/janitor.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/modular.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/nukenade.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/pyrogrenade.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/shrapnelgrenade.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/smoke.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/stingergrenade.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/supermattergrenade.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/syndgrenade.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/tear_gas.rsi
Resources/Textures/_Maid/Objects/Weapons/Grenades/whiteholegrenade.rsi
Resources/Textures/_Maid/Objects/Weapons/Melee/shields.rsi
Resources/Textures/_Maid/Structures/Machines/VendingMachines/cart.rsi
Resources/Textures/_Maid/Structures/Machines/smartfridge.rsi
Resources/Textures/_Maid/Structures/Machines/telecomms.rsi
Resources/Textures/_Maid/Structures/Piping/disposal.rsi
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR systematically migrates sprite asset references throughout the codebase to use "_Maid" prefixed texture variants, accompanied by corresponding meta.json metadata files for each new asset. Changes span prototypes, actions, catalog items, and UI elements, with all visual references updated consistently while maintaining no functional logic or behavior changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Fix all issues with AI agents
In `@CppProperties.json`:
- Around line 1-21: Remove the accidentally committed CppProperties.json from
the PR by deleting the file (CppProperties.json) from the branch and committing
that deletion, and then add an entry for CppProperties.json to .gitignore (or a
more general IDE/temp files rule) so it won’t be re-added; ensure the commit
message references removing the unintended IDE file and push the branch to
update the PR.
In `@Resources/Prototypes/_Goobstation/Entities/Objects/Weapons/grenades.yml`:
- Line 21: The PR contains an unintended gameplay change: the Sarin reagent
"Quantity" field in grenades.yml was modified; either revert the Sarin Quantity
change in
Resources/Prototypes/_Goobstation/Entities/Objects/Weapons/grenades.yml back to
the original value if this retexture PR should not alter gameplay, or if the
quantity change is intentional move that change into a separate commit/PR, add
an explicit changelog entry and update the PR description to call out the
balance change for review; locate the "Quantity" key for the Sarin reagent in
grenades.yml to make the correction or separate commit.
In `@Resources/Prototypes/Entities/Structures/Piping/Disposal/pipes.yml`:
- Line 111: The new sprite file _Maid/Structures/Piping/disposal.rsi is missing
four required animation states used by child entities (conpipe-x, conpipe-y,
pipe-signaller, pipe-x); update the RSI to add these four states with
appropriate frames/definitions matching the existing piping state conventions
(or revert the sprite path change used in the sprite: entry) so child entities
referencing those states can render; locate the sprite declaration that set
sprite: _Maid/Structures/Piping/disposal.rsi and ensure the disposal.rsi defines
conpipe-x, conpipe-y, pipe-signaller, and pipe-x state blocks consistent with
other piping RSIs.
In `@Resources/Prototypes/Entities/Structures/Piping/Disposal/units.yml`:
- Line 42: The MailingUnit sprite entry is inconsistent with DisposalUnitBase
and DisposalUnit which now reference the _Maid variant; update the MailingUnit
definition (symbol: MailingUnit) to use sprite:
_Maid/Structures/Piping/disposal.rsi (so it uses the same states like
conmailing, mailing-charging, etc.), or if there is an intentional difference,
add a clear comment/documentation in the MailingUnit definition explaining why
it must use the original Structures/Piping/disposal.rsi and list the
missing/overridden states; locate the sprite line in MailingUnit and either
change it to the _Maid path or add the explanatory comment next to the existing
sprite entry.
In `@Resources/Textures/_Maid/Clothing/Head/Hats/warden.rsi/meta.json`:
- Around line 9-17: The meta.json for the _Maid warden.rsi is missing the inhand
states required for held-item rendering; update the "states" array in meta.json
to add entries for "inhand-left" and "inhand-right" each with "directions": 4
(matching the existing "equipped-HELMET" entry), and add the corresponding
sprite files for those states to the resource bundle to match the base game and
the galoshes example so the engine can render held variants correctly.
In `@Resources/Textures/_Maid/Objects/Weapons/Melee/shields.rsi/meta.json`:
- Around line 147-149: The meta.json entry for the makeshift shield only defines
"makeshift-icon" but lacks the in-hand state entries other shields use; update
the makeshift section to add "makeshift-inhand-right" and
"makeshift-inhand-left" state names (matching the pattern used by
buckler/changeling/metal/etc.) and ensure corresponding PNG sprite files with
those exact names exist in the same folder (or update filenames to match if they
already exist), so rendering will find both inhand-right and inhand-left assets
for the makeshift shield.
🧹 Nitpick comments (7)
Resources/Prototypes/Recipes/Construction/Graphs/machines/machine.yml (1)
136-136: Nit: inconsistentDeleteEntitystyle.This line uses
!type:DeleteEntity {}while the other occurrences in this file (lines 26 and 57) use!type:DeleteEntitywithout the explicit empty mapping. Consider dropping{}for consistency.Suggested fix
- - !type:DeleteEntity {} + - !type:DeleteEntityResources/Prototypes/Catalog/Cargo/cargo_service.yml (1)
61-61: Minor comment style inconsistency:#Maidvs# Maid.Line 61 uses
#Maid(no space) while line 151 uses# Maid(with space). Consider picking one style for consistency across the file.Proposed fix
- sprite: _Maid/Objects/Weapons/Grenades/janitor.rsi `#Maid` + sprite: _Maid/Objects/Weapons/Grenades/janitor.rsi # MaidResources/Textures/_Maid/Objects/Weapons/Melee/shields.rsi/meta.json (1)
172-182: Inconsistent indentation for the changeling states.Lines 172–182 use 6-space indentation for object braces and 10-space for properties, while the rest of the file uses 4-space and 6-space respectively. This appears to be a copy-paste artifact.
🔧 Fix indentation to match the rest of the file
- { - "name": "changeling-icon" - }, - { - "name": "changeling-inhand-left", - "directions": 4 - }, - { - "name": "changeling-inhand-right", - "directions": 4 - } + { + "name": "changeling-icon" + }, + { + "name": "changeling-inhand-left", + "directions": 4 + }, + { + "name": "changeling-inhand-right", + "directions": 4 + }Resources/Textures/_Maid/Objects/Weapons/Grenades/grenade.rsi/meta.json (1)
1-22: Inconsistent JSON formatting compared to siblingmeta.jsonfiles.This file uses 4-space indentation while the other grenade
meta.jsonfiles in this PR (e.g.,nukenade.rsi,smoke.rsi) use 2-space indentation. Additionally, the key order in theequipped-BELTstate putsdirectionsbeforename(Lines 17–18), unlike thename-first convention used elsewhere. Consider normalizing for consistency.Resources/Textures/_Maid/Clothing/Hands/Gloves/Color/yellow.rsi/meta.json (1)
1-28: Inconsistent JSON formatting compared to other meta.json files in this PR.The indentation is inconsistent: the first state object (lines 9-11) is indented with 8 spaces, while subsequent state objects (lines 12, 16, 20, 23) use 4 spaces. Line 22 also has a closing brace jammed onto the same line as the value (
"directions": 4},). Compare with the cleanly formattedertengineer.rsi/meta.jsonin this same PR.♻️ Suggested formatting fix
-{"version": 1, -"license": "CC-BY-SA-3.0", -"copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/4f6190e2895e09116663ef282d3ce1d8b35c032e", -"size": { - "x": 32, - "y": 32 -}, -"states": [ - { - "name": "icon" - }, -{ - "name": "equipped-HAND", - "directions": 4 -}, -{ - "name": "inhand-left", - "directions": 4 -}, -{ - "name": "inhand-right", - "directions": 4}, -{ - "name": "equipped-HAND-vox", - "directions": 4 -} -] -} +{ + "version": 1, + "license": "CC-BY-SA-3.0", + "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/4f6190e2895e09116663ef282d3ce1d8b35c032e", + "size": { + "x": 32, + "y": 32 + }, + "states": [ + { + "name": "icon" + }, + { + "name": "equipped-HAND", + "directions": 4 + }, + { + "name": "inhand-left", + "directions": 4 + }, + { + "name": "inhand-right", + "directions": 4 + }, + { + "name": "equipped-HAND-vox", + "directions": 4 + } + ] +}Resources/Prototypes/Entities/Structures/Machines/telecomms.yml (1)
120-159: Large block of commented-out visualizer config should be cleaned up.Same concern as above — the old
GenericVisualizerentries for per-variant shader toggling (lines 124–159) are commented out. If the new sprite doesn't support these states, remove the dead config. If it does, adapt it to work with the new sprite.Resources/Prototypes/Catalog/uplink_catalog.yml (1)
961-961: Updating a commented-out icon path is unnecessary.This line is inside a fully commented-out listing block. Updating dead config adds noise to the diff without functional benefit.
| reagents: | ||
| - ReagentId: Sarin | ||
| Quantity: 50 No newline at end of file | ||
| Quantity: 50 |
Contributor
There was a problem hiding this comment.
Unrelated gameplay change in a retexture PR — Quantity for Sarin reagent was modified.
This line is marked as changed, but the PR is described as a retexture. Changing the Sarin reagent quantity is a balance/gameplay change that should be called out separately in the changelog and reviewed independently. Confirm this change is intentional and not accidental.
🤖 Prompt for AI Agents
In `@Resources/Prototypes/_Goobstation/Entities/Objects/Weapons/grenades.yml` at
line 21, The PR contains an unintended gameplay change: the Sarin reagent
"Quantity" field in grenades.yml was modified; either revert the Sarin Quantity
change in
Resources/Prototypes/_Goobstation/Entities/Objects/Weapons/grenades.yml back to
the original value if this retexture PR should not alter gameplay, or if the
quantity change is intentional move that change into a separate commit/PR, add
an explicit changelog entry and update the PR description to call out the
balance change for review; locate the "Quantity" key for the Sarin reagent in
grenades.yml to make the correction or separate commit.
| - type: Sprite | ||
| drawdepth: ThickPipe | ||
| sprite: Structures/Piping/disposal.rsi | ||
| sprite: _Maid/Structures/Piping/disposal.rsi #Maid |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
echo "=== Check new RSI exists ==="
fd --type d "disposal.rsi" --full-path "Resources/Textures/_Maid/Structures/Piping"
echo ""
echo "=== States referenced by child entities in this file ==="
rg -oP "state:\s*\K[\w-]+" "Resources/Prototypes/Entities/Structures/Piping/Disposal/pipes.yml" | sort -u
echo ""
echo "=== States defined in new meta.json ==="
fd -t f "meta.json" --full-path "Resources/Textures/_Maid/Structures/Piping/disposal.rsi" --exec cat {} 2>/dev/null | python3 -c "
import json, sys
try:
data = json.load(sys.stdin)
for s in data.get('states', []):
print(s['name'])
except:
print('No meta.json found or parse error')
" | sort -uRepository: TheMaidDev/Maid-14
Length of output: 1186
Critical: New RSI is missing required states — sprite change will break child entities.
The new _Maid/Structures/Piping/disposal.rsi exists but is incomplete. Child entities reference 28 states total, but the RSI is missing 4 required states:
conpipe-xconpipe-ypipe-signallerpipe-x
These entities will fail to render. Either add the missing states to the RSI or revert the sprite path change.
🤖 Prompt for AI Agents
In `@Resources/Prototypes/Entities/Structures/Piping/Disposal/pipes.yml` at line
111, The new sprite file _Maid/Structures/Piping/disposal.rsi is missing four
required animation states used by child entities (conpipe-x, conpipe-y,
pipe-signaller, pipe-x); update the RSI to add these four states with
appropriate frames/definitions matching the existing piping state conventions
(or revert the sprite path change used in the sprite: entry) so child entities
referencing those states can render; locate the sprite declaration that set
sprite: _Maid/Structures/Piping/disposal.rsi and ensure the disposal.rsi defines
conpipe-x, conpipe-y, pipe-signaller, and pipe-x state blocks consistent with
other piping RSIs.
| vaultable: false | ||
| - type: Sprite | ||
| sprite: Structures/Piping/disposal.rsi | ||
| sprite: _Maid/Structures/Piping/disposal.rsi #Maid |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# First, locate the units.yml file and verify its content
find . -type f -name "units.yml" -path "*Disposal*" | head -5Repository: TheMaidDev/Maid-14
Length of output: 130
🏁 Script executed:
#!/bin/bash
# Also search for the RSI files to understand the directory structure
fd "disposal.rsi" --type dRepository: TheMaidDev/Maid-14
Length of output: 233
🏁 Script executed:
#!/bin/bash
# Look for meta.json files in RSI directories to understand states
fd "meta.json" --path "*disposal.rsi*"Repository: TheMaidDev/Maid-14
Length of output: 277
🏁 Script executed:
#!/bin/bash
# Read the units.yml file to see the sprite references and entities
cat -n ./Resources/Prototypes/Entities/Structures/Piping/Disposal/units.yml | head -200Repository: TheMaidDev/Maid-14
Length of output: 8353
🏁 Script executed:
#!/bin/bash
# Check meta.json in both disposal.rsi directories
echo "=== Original disposal.rsi meta.json ===" && \
cat "Resources/Textures/Structures/Piping/disposal.rsi/meta.json" && \
echo "" && \
echo "=== _Maid disposal.rsi meta.json ===" && \
cat "Resources/Textures/_Maid/Structures/Piping/disposal.rsi/meta.json"Repository: TheMaidDev/Maid-14
Length of output: 28940
Update MailingUnit to use the _Maid variant or clarify why it differs.
The _Maid/Structures/Piping/disposal.rsi actually contains all required states including mailing-specific ones (conmailing, mailing, mailing-charging, mailing-flush, mailover-handle). Since DisposalUnitBase and DisposalUnit now reference the _Maid variant, MailingUnit should either be updated to match for consistency, or the reason for keeping it on the original Structures/Piping/disposal.rsi should be documented.
🤖 Prompt for AI Agents
In `@Resources/Prototypes/Entities/Structures/Piping/Disposal/units.yml` at line
42, The MailingUnit sprite entry is inconsistent with DisposalUnitBase and
DisposalUnit which now reference the _Maid variant; update the MailingUnit
definition (symbol: MailingUnit) to use sprite:
_Maid/Structures/Piping/disposal.rsi (so it uses the same states like
conmailing, mailing-charging, etc.), or if there is an intentional difference,
add a clear comment/documentation in the MailingUnit definition explaining why
it must use the original Structures/Piping/disposal.rsi and list the
missing/overridden states; locate the sprite line in MailingUnit and either
change it to the _Maid path or add the explanatory comment next to the existing
sprite entry.
Comment on lines
+9
to
+17
| "states": [ | ||
| { | ||
| "name": "icon" | ||
| }, | ||
| { | ||
| "name": "equipped-HELMET", | ||
| "directions": 4 | ||
| } | ||
| ] |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if the original warden.rsi has inhand states
echo "=== Original warden.rsi meta.json (excluding _Maid) ==="
fd -t f 'warden.rsi/meta.json' --exclude '_Maid' --exec cat {} 2>/dev/null || echo "Not found or error"
echo ""
echo "=== Maid warden.rsi meta.json ==="
fd -t f 'meta.json' '_Maid/Clothing/Head/Hats/warden.rsi/' --exec cat {} 2>/dev/null || echo "Not found"
echo ""
echo "=== All files in _Maid warden.rsi directory ==="
fd -t f . '_Maid/Clothing/Head/Hats/warden.rsi/' 2>/dev/null || echo "Not found"
echo ""
echo "=== Check galoshes.rsi meta.json for comparison ==="
fd -t f 'meta.json' '_Maid/Clothing/Feet/Shoes/galoshes.rsi/' --exec cat {} 2>/dev/null || echo "Not found"
echo ""
echo "=== List all warden.rsi locations in repo ==="
find . -name 'warden.rsi' -type d 2>/dev/null || echo "None found"Repository: TheMaidDev/Maid-14
Length of output: 972
🏁 Script executed:
#!/bin/bash
echo "=== Contents of _Maid warden.rsi directory ==="
ls -la ./Resources/Textures/_Maid/Clothing/Head/Hats/warden.rsi/ 2>&1
echo ""
echo "=== Contents of base game warden.rsi (Head/Hats) ==="
ls -la ./Resources/Textures/Clothing/Head/Hats/warden.rsi/ 2>&1
echo ""
echo "=== Meta.json from base game warden.rsi ==="
cat ./Resources/Textures/Clothing/Head/Hats/warden.rsi/meta.json 2>&1
echo ""
echo "=== Search for galoshes.rsi anywhere ==="
find . -name 'galoshes.rsi' -type d 2>/dev/null
echo ""
echo "=== Search for any .rsi directories in _Maid/Clothing ==="
find ./Resources/Textures/_Maid/Clothing -name '*.rsi' -type d 2>/dev/null | head -20Repository: TheMaidDev/Maid-14
Length of output: 3035
🏁 Script executed:
#!/bin/bash
echo "=== _Maid warden.rsi meta.json ==="
cat ./Resources/Textures/_Maid/Clothing/Head/Hats/warden.rsi/meta.json
echo ""
echo "=== Base game galoshes.rsi meta.json ==="
cat ./Resources/Textures/Clothing/Shoes/Specific/galoshes.rsi/meta.json
echo ""
echo "=== _Maid galoshes.rsi contents ==="
ls -la ./Resources/Textures/_Maid/Clothing/Shoes/Specific/galoshes.rsi/
echo ""
echo "=== _Maid galoshes.rsi meta.json ==="
cat ./Resources/Textures/_Maid/Clothing/Shoes/Specific/galoshes.rsi/meta.json 2>&1Repository: TheMaidDev/Maid-14
Length of output: 1969
Add missing inhand-left and inhand-right states.
The _Maid warden.rsi is missing both the sprite files and meta.json state declarations for inhand-left and inhand-right. The base game version includes these with 4 directional variants, which are needed for proper rendering when the item is held. The _Maid galoshes.rsi added in this same PR correctly includes these inhand states, providing a working example in the same module.
Base game comparison (has inhand states)
{
"states": [
{ "name": "icon" },
{ "name": "equipped-HELMET", "directions": 4 },
{ "name": "inhand-left", "directions": 4 },
{ "name": "inhand-right", "directions": 4 }
]
}
🤖 Prompt for AI Agents
In `@Resources/Textures/_Maid/Clothing/Head/Hats/warden.rsi/meta.json` around
lines 9 - 17, The meta.json for the _Maid warden.rsi is missing the inhand
states required for held-item rendering; update the "states" array in meta.json
to add entries for "inhand-left" and "inhand-right" each with "directions": 4
(matching the existing "equipped-HELMET" entry), and add the corresponding
sprite files for those states to the resource bundle to match the base game and
the galoshes example so the engine can render held variants correctly.
Comment on lines
+147
to
+149
| { | ||
| "name": "makeshift-icon" | ||
| }, |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if makeshift inhand PNGs exist in this RSI directory
fd 'makeshift' Resources/Textures/_Maid/Objects/Weapons/Melee/shields.rsi/ --type fRepository: TheMaidDev/Maid-14
Length of output: 139
🏁 Script executed:
#!/bin/bash
# List all files in the shields RSI directory to see what exists
ls -la Resources/Textures/_Maid/Objects/Weapons/Melee/shields.rsi/Repository: TheMaidDev/Maid-14
Length of output: 2459
🏁 Script executed:
#!/bin/bash
# Extract all state definitions from meta.json to see the pattern
cat Resources/Textures/_Maid/Objects/Weapons/Melee/shields.rsi/meta.json | jq '.states[] | {name: .name}' | head -50Repository: TheMaidDev/Maid-14
Length of output: 650
🏁 Script executed:
#!/bin/bash
# Extract all makeshift state definitions from meta.json
cat Resources/Textures/_Maid/Objects/Weapons/Melee/shields.rsi/meta.json | jq '.states[] | select(.name | startswith("makeshift"))'Repository: TheMaidDev/Maid-14
Length of output: 92
makeshift is missing inhand state definitions and sprites — every other shield has them.
The meta.json for makeshift only defines makeshift-icon, while all other shields (buckler, changeling, metal, mirror, ratvarian, riot, riot_bullet, riot_laser, teleriot) define -icon, -inhand-right, and -inhand-left states with corresponding PNG files. If makeshift is meant to be equippable in-hand, the missing states and sprites will cause rendering failures when held.
🤖 Prompt for AI Agents
In `@Resources/Textures/_Maid/Objects/Weapons/Melee/shields.rsi/meta.json` around
lines 147 - 149, The meta.json entry for the makeshift shield only defines
"makeshift-icon" but lacks the in-hand state entries other shields use; update
the makeshift section to add "makeshift-inhand-right" and
"makeshift-inhand-left" state names (matching the pattern used by
buckler/changeling/metal/etc.) and ensure corresponding PNG sprite files with
those exact names exist in the same folder (or update filenames to match if they
already exist), so rendering will find both inhand-right and inhand-left assets
for the makeshift shield.
an unnecessary file has been deleted
Resources/Textures/_Maid/Objects/Devices/encryption_keys.rsi: PNG not defined in metadata: borg_label.png Resources/Textures/_Maid/Structures/Piping/disposal.rsi: PNG not defined in metadata: pipe-xf.png Resources/Textures/_Maid/Structures/Piping/disposal.rsi: PNG not defined in metadata: pipe-signaller.png Resources/Textures/_Maid/Structures/Piping/disposal.rsi: PNG not defined in metadata: pipe-x.png Resources/Textures/_Maid/Structures/Storage/wall_locker.rsi: PNG not defined in metadata: n2_door.png Resources/Textures/_Maid/Structures/Storage/wall_locker.rsi: PNG not defined in metadata: n2.png
conpipe signaller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🆑 4esterNight
Summary by CodeRabbit